Remove gripper_controllers dependency #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package got removed upstream and it seems not to be used in thispackage, anyway.
sea-bass
approved these changes
Jun 29, 2025
There was a problem hiding this comment.
This looks fine, and seems like the new version is available on Jazzy anyway...
One note is that the build will probably fail because the dependency is still there in the ros2_kortex repo that is pulled in here.
Specifically, the gripper controller plugins need to be updated to the new parallel_gripper_action_controller/GripperActionController:
I suspect that will be needed as well to fix the build, but that can be done independently of this PR.
|
Docs CI failures fixed in #1052 btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package got removed upstream in ros-controls/ros2_controllers#1652. Find_packageing this on Kilted or Rolling will lead to errors from the next sync on.